Images do not load after confirmation when using S3 storage backend (v0.2.3a0)

TrangPham / django-admin-confirm

AdminConfirmMixin is a mixin for ModelAdmin that adds confirmations to changes, additions and actions.

Other

129 stars 16 forks source link

Images do not load after confirmation when using S3 storage backend (v0.2.3a0) #24

Closed TrangPham closed 2 years ago

TrangPham commented 3 years ago

@TrangPham , HI! How does uploading images after the confirmation form work now?

My images don't load on S3 if the confirmation form was called

Originally posted by @IRemsha in https://github.com/TrangPham/django-admin-confirm/issues/8#issuecomment-798873574

TrangPham commented 3 years ago

@IRemsha I've updated the code that handles the file caching in v0.2.4. I was wondering if you could test the S3 upload again?

I've been trying to set up localstack to create integration tests for S3. I unfortunately do not have my own AWS set up to test.

TrangPham commented 2 years ago

Tested this again locally with v1.0.0a0 Django 4.0 and Python 3.8. Was able to see new image uploaded to localstack. Feel free to re-open this issue if you see this occurring again for S3.