Adding localstack to docker and S3 file storage testing - Githubissues

TrangPham / django-admin-confirm

AdminConfirmMixin is a mixin for ModelAdmin that adds confirmations to changes, additions and actions.

Other

128 stars 16 forks source link

Adding localstack to docker and S3 file storage testing #26

Closed TrangPham closed 3 years ago

TrangPham commented 3 years ago

For testing S3 storage backend

TrangPham commented 3 years ago

CI:

running in host network_mode with selenium and localstack as GitHub Actions services

Dev:

running in bridge mode for localstack, within the docker container uses host.docker.internal

Notes:

It took forever to get the localstack tests running on Github Actions
Having the localstack started by the docker-compose.yml file made it not accessable
Services in Github Actions can be accessed from localhost
Services accessing each other in docker containers use host.docker.internal
LOCALSTACK_HOST is a variable used by localstack-python-client (localstack_client). localstack_client is used in the s3 integration tests