fix(Issue-27): Confirmations not triggered on models with validation failures - Githubissues

TrangPham / django-admin-confirm

AdminConfirmMixin is a mixin for ModelAdmin that adds confirmations to changes, additions and actions.

Other

129 stars 16 forks source link

fix(Issue-27): Confirmations not triggered on models with validation failures #30

Closed TrangPham closed 3 years ago

TrangPham commented 3 years ago

There are a bunch of changes here.

Integration tests added for validations
bug in the code wherein form = ModelForm(request.POST, request.FILES, obj) should have been form = ModelForm(request.POST, request.FILES, instance=obj)

Constants added:

ADMIN_CONFIRM_CACHE_KEY_PREFIX for the FileCache
ADMIN_CONFIRM_DEBUG which will control internal logging for the module (mostly added this for easier debugging for myself)
ADMIN_CONFIRM_CACHE_TIMEOUT changed from default 10 -> 1000

Other major changes:

Stopped caching the request.POST
Added FileCache (this is taken from: https://github.com/MaistrenkoAnton/filefield-cache/blob/master/filefield_cache/cache.py, MIT License added and credit given to the above)

Other notes:

still caching object - although it may not be needed.

Relates to: #27