search

TransGirlCodes / Phylogenetics.jl

The Julia package for analysis of evolution and phylogeny
Other
6 stars 8 forks source link

Fix #1. #2

Closed porterjamesj closed 11 years ago

porterjamesj commented 11 years ago

The basic problem seems to have been that using an array comprehension to transform nodeLabel caused uncertainty about the types, resulting in the Union type. Sorry about all the formatting nonsense, I have my editor set up to strip whitespace and a few other things on save :/

TransGirlCodes commented 11 years ago

Thanks for noticing this, I hope to get back to working on this repo soon but I have another project using R, which is being worked on for a paper and it's proving a lot more work than it first appeared.

porterjamesj commented 11 years ago

Would you mind if I went through and did some refactoring/style changes/new features? I'm about to start a project that I'd love to use this library for but I'd like to clean it up a bit first and add some stuff I need to it.

TransGirlCodes commented 11 years ago

That would be great, if you could explain changes and features you add and keep me posted that would be awesome.

The history of the thing was that I began it simply as an implementation of the R ape package and I began with the functions to read in newick trees and represent them. I have a branch called phyxml I was making to allow highly annotated trees represented in a recursive format and read from and written to files in phyxml format. I can't remember how far I got with this though.

It's great that other people are interested in this, I was also hoping to get a good compatibility with the bioseq.jl package. I hope to start working with it again ASAP.

Best, Ben

On 19 Oct 2013, at 18:59, "James Porter" notifications@github.com<mailto:notifications@github.com> wrote:

Would you mind if I went through and did some refactoring/style changes/new features? I'm about to start a project that I'd love to use this library for but I'd like to clean it up a bit first and add some stuff I need to it.

— Reply to this email directly or view it on GitHubhttps://github.com/Ward9250/Phylogenetics.jl/pull/2#issuecomment-26655278.