search

TransferORM / transfer

ColdFusion ORM library created by Mark Mandel, updated by @ghidinelli
Other
5 stars 3 forks source link

SQLValue always returns false for Railo on null values #13

Open bdw429s opened 9 years ago

bdw429s commented 9 years ago

https://github.com/TransferORM/transfer/blob/master/com/sql/SQLValue.cfc#L93 Why is false always being returned here on the line of code linked above? Shouldn't we return:

arguments.query.getString(arguments.property.getColumn());
ghidinelli commented 9 years ago

Great question - I don't run railo/lucee (yet) so I think the update comes from here: https://groups.google.com/forum/#!msg/transfer-dev/xkAux83LIg0/XxL57mriI34J

Your solution... looks more correct. If you change it, does it run and do the unit tests pass?

bdw429s commented 9 years ago

I haven't tried the unit tests (are there some docs on how to run those) but it did cause my app to stop erroring :)

bdw429s commented 9 years ago

OH, I can submit a pull for that change if you like too.

ghidinelli commented 9 years ago

The tests are here: https://github.com/TransferORM/tests

Basically map them in, there are sql files in resources/sql (but it should auto create them, the only thing is you need to indicate somewhere what kind of DB you have I think), and then let them rip. They are MXUnit.

I don't know if anyone has run them on Railo/Lucee recently so it would be great just to see if they even run?? I ran them on ACF a few months ago.