search

TransforMap / data.transformap.co

Here you find a Node.js daemon to serve the public TransforMap web service.
https://data.transformap.co
GNU Affero General Public License v3.0
7 stars 2 forks source link

promisifying server start #26

Closed maxlath closed 8 years ago

maxlath commented 8 years ago

americano.start isn't aware of promises so it needs to be promisified to stay the consistent with the rest of the code base: having callbacks in the middle of a promise chain is rather ugly and makes things seem hard to refactor

almereyda commented 8 years ago

The same case as in https://github.com/TransforMap/transformap-api/pull/25#issuecomment-186432087 applies. Cannot merge this from here right now, despite it looks nice.

maxlath commented 8 years ago

@almereyda I don't get why that would be blocking for this PR

almereyda commented 8 years ago

Hmm, in a sense I cannot get americano.start to test it, if no further documentation is provided to make it work.

almereyda commented 8 years ago

You were right.

My error as of 73a2c36b6a56ea1f96af0f89f70bf0968df9dd97