TransforMap / data.transformap.co

Here you find a Node.js daemon to serve the public TransforMap web service.
https://data.transformap.co
GNU Affero General Public License v3.0
7 stars 2 forks source link

Universal path breaks with Dokku deployment. #32

Closed almereyda closed 8 years ago

almereyda commented 8 years ago

When deploying 3dc9564, I recieve

       -----
       module.js:327
           throw err;
           ^
       Error: Cannot find module 'bluebird'
           at Function.Module._resolveFilename (module.js:325:15)
           at Function.Module._load (module.js:276:25)
           at Module.require (module.js:353:17)
           at require (internal/module.js:12:17)
           at Object.<anonymous> (/app/server/lib/promises.js:2:18)
           at Module._compile (module.js:409:26)
           at Object.Module._extensions..js (module.js:416:10)
           at Module.load (module.js:343:32)
           at Function.Module._load (module.js:300:12)
           at Module.require (module.js:353:17)
           at require (internal/module.js:12:17)
           at Object.req [as require] (/app/config/universal_path.js:22:10)
           at Object.<anonymous> (/app/db/init.js:6:22)
           at Module._compile (module.js:409:26)
           at Object.Module._extensions..js (module.js:416:10)
           at Module.load (module.js:343:32)

Am trying a more manual deployment approach now.

maxlath commented 8 years ago

that make sense: in server/lib/promises.js:2 line 2 (as pointed from the stack trace), we require bluebird:

const bluebird = require('bluebird')

but bluebird isn't in package.json dependencies (lines 27 to 36), thus it wasn't installed at deployment.

This can be fixed simply adding bluebird to the dependencies like so:

npm install --save bluebird
almereyda commented 8 years ago

Yes, a4a3682 resolves this.