let maps show some interesting data

[thoka]

currently maps point to more or less nowhere

let them point to places, where some data exists

[species]

I've commited better places in d4860b7351213ebcdc8f6bcf598ea62f07cdcfb3, please deploy (as I am not able to run docpad atm).

[thoka]

deployed

On Mon, May 4, 2015 at 3:06 PM, Michael Maier notifications@github.com wrote:

I've commited better places in d4860b7 https://github.com/TransforMap/transformap.github.io/commit/d4860b7351213ebcdc8f6bcf598ea62f07cdcfb3, please deploy (as I am not able to run docpad atm).

— Reply to this email directly or view it on GitHub https://github.com/TransforMap/transformap.github.io/issues/4#issuecomment-98700604 .

[species]

which branch/fork is currently deployed on transformap.co? the text below the maps links correctly, but the images itself still to zoomlevel 3 - but i cannot find matching source files anywhere :-/

[almereyda]

Have a look into https://github.com/TransforMap/transformap.github.io/blob/source/src/render/index.html.eco

On 11 May 2015 at 09:49, Michael Maier notifications@github.com wrote:

which branch/fork is currently deployed on transformap.co? the text below the maps links correctly, but the images itself still to zoomlevel 3 - but i cannot find matching source files anywhere :-/

— Reply to this email directly or view it on GitHub https://github.com/TransforMap/transformap.github.io/issues/4#issuecomment-100802712 .

[species]

WTF?!? Apart from broken HTML (unclosed -tags, 's inside 's ) in there, framework and content was mixed up badly. Fixed in 2db58faac24ad7f62d0bb4b0a588c3afd21ae8c3. Please test and deploy :-)

Please calm down. You know https://github.com/TransforMap/transformap.github.io/commit/36b9d07d2f824d5ba7502bddda9c0245feca8a78 had been added in the last seconds before departing to the train.

The mix of templating and content is now even extended, that the *.md files carry plain HTML.

As long as we don't automatically create the maps list, fighting for strict seperation here could mean overoptimization.

Just put the links in the template maybe? So logic (links) will be seperate from content (image, text). In the end we still align the partials manually to their respective maps.

---

@thoka @species

As of https://github.com/keikreutler/transformap/pull/5#issuecomment-98523535 I want to revert 8a83052 so we can switch to a Pull Request driven merge-and-deploy workflow as we agreed.

[almereyda]

@gandhiano @species @thoka @keikreutler For comparison: This is how bad mixing of the MVCU pattern looks like. ~ advise ~ scrub the presentation at least (hover > onmousemove)

Note: co-munity.net is based on Open Atrium 2, which is based on drupal, which is written in PHP.

[gandhiano]

What you see has nothing to do with PHP, Drupal or Open Atrium, but rather missing configuration and testing of the input filters (only the standard WYSIWYG has been somewhat thoroughly tested).

Also don't understand what this has to do with the concrete issue.

[almereyda]

But the MarkDown input filter is not implemented in PHP and runs on Drupal used by a module in your Open Atrium instance? Or did you mean it's implemented in JavaScript and runs only client side, after rendering the DOM? Then how come the drupal HTML leaks into it?

For relation to the issue: I wanted to give an example where a bad separation of models and views, which is by definition already artificial, leads to unwanted side effects.

[gandhiano]

Markdown in Drupal is a text filter, which can be used in an input format. The filter just does some string conversion and stores it in the database (and reads from the database to prepare the proper HTML). The input format (which in the case I implemented is also called MarkDown) is a combination of different filters. Input formats can also have their own frontends/editors - this is where I want to extend the current crappy editor by setting up this apparently nice Markdown Editor for BUEeditor with AJAX support for preview without reload (I guess with some coding one could even get the Markdown to automatically display on another form on the same page)

The reason why you have the HTML code appearing there has probably to do with a (automatic) switching between input formats, due to a faulty implementation, at least in the discussion replies (not sure if OA related, or my own setup of input formats, but will try to address this on the next update).

In this sense, I think Drupal makes here a quite good separation of models and views - the models are provided here by the filters, the views by the editors. Input filters are mostly model, but make the bridge to specific views.

[species]

Thanks for deploying! ☺ May I close this issue, or do you need it for discussions?