Fixed Attention==1 Looking Black

TransformerLensOrg / CircuitsVis

Mechanistic Interpretability Visualizations using React

https://alan-cooney.github.io/CircuitsVis/

MIT License

192 stars 29 forks source link

Fixed Attention==1 Looking Black #28

Closed neelnanda-io closed 1 year ago

neelnanda-io commented 1 year ago

Luminance was set to 1 - attn value, so attn=1 was set to luminance 0, ie black, which IMO looks worse than an intense shade in that head's colour. Added a fix.

(There's a bunch of random janky commits in here from my fork, but which on net seem to have zero change to the underlying files? Not sure if that messes up anything in your library lol).

alan-cooney commented 1 year ago

React tests are failing - but it's just a snapshot test for colours so yarn test --updateSnapshot should fix it