TransitTrack / transittrack

Transit Track application used for monitoring vehiles and generate predictions
GNU General Public License v3.0
0 stars 0 forks source link

The 'next' version - Predictions table issue #47

Open TsimurSh opened 1 month ago

TsimurSh commented 1 month ago

Hi @vesavlad, could you please review the Predictions model in the next branch, specifically the isArrival field? I’m concerned that it's consistently returning a status of true, which doesn't compare to previous version transit clock where almost always status is false.

vesavlad commented 1 month ago

Please check what config you have set for this:

transitclock.factory.prediction-generator

By default is

org.transitclock.core.prediction.PredictionGeneratorDefaultImpl

This would set the value referred to false if some conditions are met in generatePredictionForStop method.

vesavlad commented 1 month ago

also it looks like public static BooleanConfigValue useArrivalPredictionsForNormalStops = new BooleanConfigValue( "transitclock.core.useArrivalPredictionsForNormalStops", true, "For specifying whether to use arrival predictions or "

is still not refactored out to be picked from new config format.