search

TransitionbyDesign / homemaker

GNU Affero General Public License v3.0
0 stars 1 forks source link

Side box with legend #59

Open wu-lee opened 3 years ago

wu-lee commented 3 years ago

Down arrow in title bar minimises to bottom.

As per @JasLewicki 2/11 feedback document

Charlie-TbD commented 3 years ago

I wasn't seeing this as an 'if time permits issue'. Its been in the brief from the very beginning of the project - see my Whimsical wireframe which we went through in the Notion brief in the first week of the project https://whimsical.com/homemaker-engagement-platform-4PRLUpz1hdkoZiLpvGsdFt@2Ux7TurymQbCgNtk4uNU and which Jas used to design his first wireframe which includes it. The website map page looks empty without this and doesn't have anything to explain it.

Although we discussed putting this text and a legend in the splash page I'm not happy with this resolution.

wu-lee commented 3 years ago

Ok. I can't promise anything, but trying to be constructive, if you review and prioritise all issues like this, I will see if I can find time to add the most important things in whatever spare time I can donate.

Charlie-TbD commented 3 years ago

I understand its tricky just want to be clear here that it's been talked about and visualised throughout. Adding the legend icons within this box is newer based on using the map and seeing how confusing it would be for a visitor.

On Wed, 18 Nov 2020, 22:59 wu-lee, notifications@github.com wrote:

Ok. I can't promise anything, but trying to be constructive, if you review and prioritise all issues like this, I will see if I can find time to add the most important things in whatever spare time I can donate.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/TransitionbyDesign/homemaker/issues/59#issuecomment-729982962, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARHKWLQEC5CZ3SYINXRNAADSQQ7VLANCNFSM4TKSYURQ .

wu-lee commented 3 years ago
wu-lee commented 3 years ago

Notes.

Customisable text in sidebar

Sidebar text is customisable in Forestry.io - both that above the legend (which comes from the main form content) and that below (which comes from legend_text).

However, the legend itself is hard-wired in the code and not editable through Forestry.io (although it is via GitHub, of course.) This is because the icons can't be inserted in a tabular layout using markdown or HTML in straightforward way. I concluded that since the pin icons are hardwired anyway, it would be most expedient just to hardwire the legend too.

In @JasLewicki 's mock-up, there is some text below a horizontal rule, underneath the legend (this is what the forestry.io legend_text field was added to support). I had some trouble replicating this without dismantling the consistent behaviour shared between the sidebar, the map pop-ups, and the article pages, where all the windows have a horizontal rule above a footer which contains the button and other links. In any case, the footer is not really a suitable place for text, because it doesn't scroll, and isn't very roomy. When I tried adding the text there it not only looked a bit odd, but on small displays it used up all the space, making the legend barely visible.

So although I could try and make those ends meet somehow, it seems wise to discuss this. If there's a link to another page which can be more verbose without running into layout problems, does it need to do much more than introduce the map and show a legend?

Link button goes to a longer article, and the general case of multiple unmapped articles

The button link is configurable on forestry.io. Any valid URL, or a local path should work.

The general case of multiple arbitrary unmapped articles is already possible: simply don't add any sort of location, and an article won't be on the map (lat/lng used to be required, but since the regions were added, neither are required).

Therefore I've added an unmapped "About Homemaker Oxford" page and linked to that (/map/about-homemaker-oxford). It's very basic, so you will want to edit it.

Equally, however, you could link to some external URL.

"Legend" header font/alignment

I've left the styling of the legend header the same as that used in other windows, more or less.

In @JasLewicki's demo, it is blue, left-aligned text. If this is really wanted, do we want for consistency to change the headers elsewhere? (Currently in articles, headings are the same colour as text, i.e. grey.)

Allow legend to be minimised

Minimised, the sidebar window shrinks to a button, and goes 50% transparent to avoid interfering with map too much.

Sidebar text overflow

A scroll bar is added in the case when the content overflows the size of the window.

Charlie-TbD commented 3 years ago

The sidebar minimised and stays minimised when read more is clicked. It should stay open in this case. It should only minimise when the minimise button is clicked (in the case that it's getting in the way of something that a user is reading on their phone).

For note on your documentation rather than action: Understood on the way this works although more to be done on making this sidebar useful. The website doesn't currently give a good indication of what to do when you arrive on it and the sidebar is the opportunity to help. I think this is an issue with the contents of the sidebar and it might be worth grouping issues into what a user wants to read about...the legend headings would be better being about clustered issues that Oxford struggles with rather than the media. Our issue now is that the legend isn't editable from Forestry as you note.