search

TransitionbyDesign / homemaker

GNU Affero General Public License v3.0
0 stars 1 forks source link

Set the max width of articles to much larger than currently #60

Open wu-lee opened 3 years ago

wu-lee commented 3 years ago

We want to avoid gaps at the edge of the display.

Exact amount may need discussion with @JasLewicki

wu-lee commented 3 years ago

This refers to the maximum width that full article windows will grow to before they stop - otherwise on letterbox displays the windows will get very long and start looking mis-proportioned, with very wide text rows and huge images compared to the text.

The difficulty is where to put the Homemaker logo when that happens. If the logo is always flush left, then there is a rather weird mis-alignment between the window edge and the logo.

Currently the logo is aligned with the edge of the window in all cases.

By increasing the size of this maximum we pus the problem off to unusually large displays, but at the cost of potentially very wide looking articles (although this also depends on the display's aspect ratio) I think the conclusion is that this is deemed acceptable.

Currently the maximum is set by modal-max-width in layouts.scss and is set to 120rem on all displays. This means it doesn't kick in on my 1920x1080 display, which is quite wide.