Transkribus / TWI-edit

[DEPRECATED] editing app for Transkribus Web Interface
GNU General Public License v3.0
3 stars 1 forks source link

Avoid very small edit box #12

Closed cziaarm closed 7 years ago

cziaarm commented 7 years ago

Edit box width is relative to text region initially highlighted.

This can sometimes result in edit boxes that are too small. Maybe have a fixed 65% of image (ie manuscript page) width edit box?

Lookihere: Acceptance criteria with a check box :)

kansallisarkisto commented 7 years ago

I have now written (and will soon push) code which calculates the width of text for other purposes. How about reusing that so that the width of the edit box = the length of the longest line? Possibly also so that the box grows as the longest line grows? Some users requested that.

kansallisarkisto commented 7 years ago

I'm working on enlarging the box according to line length and will also ensure that all the buttons fit on one line, which was reported as #31

cziaarm commented 7 years ago

URL https://transkribus.eu/readTest/edit/correct/2305/23316/1?tco=0&view=i chrome 60.0.3112.101 firefox 45.0.2

Width seems reasonable but it appears that the height of the edit box is less than it should be:

twi-edit-18.png

Steps taken were to click on a small word on the image before any others.

cziaarm commented 7 years ago

https://transkribus.eu/readTest/edit/correct/2305/23314/1

kansallisarkisto commented 7 years ago

Both width and height should be ok now.

cziaarm commented 7 years ago

I made some acceptance criteria for this issue (belatedly). It has a checkbox! Latest deployment now passes those acceptance criteria when testing against the case highlighted above.