search

Transkribus / TWI-edit

[DEPRECATED] editing app for Transkribus Web Interface
GNU General Public License v3.0
3 stars 1 forks source link

Tag check box does not remove tag #15

Closed cziaarm closed 7 years ago

cziaarm commented 7 years ago

Clicking on a tag name will toggle the tag fine, but the check box only toggles one way (ie on)

kansallisarkisto commented 7 years ago

I need to know more about reproducing this. For me it works perfectly in both Firefox and Chrome.

hackmanschorsch commented 7 years ago

Have you tested on readTest or your development environment? I have tested on readTest and Firefox 53.0.3. So for the checkbox only selection is possible. Pressing once more clears the checkbox but not the tag line.

kansallisarkisto commented 7 years ago

I've now tested readTest with the following:

Chromium: Version 58.0.3029.110 Built on Ubuntu , running on LinuxMint 18.1 (64-bit) Firefox: 53.0.3 (64-bit)

I can't reproduce the problem with either one of those browsers. Try again? Maybe it was an older version?

hackmanschorsch commented 7 years ago

Problem persists on Firefox 54.0.1 (32-Bit). Easy fix would be to allow tag selection only on the text rather then the checkbox. But a smarter fix would be preferable.

kansallisarkisto commented 7 years ago

I did some testing, the problem with removing tags only occurs if you open the tag menu and add a tag and then click to remove it without closing the tag menu in between. If you close the menu and open it again, it works fine. I will try to track this down, anyway.