search

TranslatorSRI / NodeNormalization

Service that produces Translator compliant nodes given a curie
MIT License
9 stars 6 forks source link

/get_semantic_types inop? #178

Open edeutsch opened 1 year ago

edeutsch commented 1 year ago

We used to get our types with this endpoint: https://smart-api.info/ui/400f7c11028ff36f460af4ea85dc72f5#/default/get_semantic_types_handler_get_semantic_types_get

But now all it ever returns is a 404.

$ curl -X 'GET' 'https://nodenormalization-sri.renci.org/1.3/get_semantic_types' -H 'accept: application/json'
{"detail":"No semantic types discovered."}

Can this endpoint be made to work again?

gaurav commented 9 months ago

This endpoint is now working again on NodeNorm Dev (https://smart-api.info/ui/95b84739a360f89aff4ea1364c2ac242#/default/get_semantic_types_handler_get_semantic_types_get), but for some reason has lots of duplicates. I'll see if I can fix that, and then hopefully we can push these changes to ITRB soon.

gaurav commented 7 months ago

Uniquifying semantic types is now implemented in https://github.com/TranslatorSRI/NodeNormalization/pull/232, but we should probably figure out why we're writing this into the database incorrectly (I'm tracking that at https://github.com/TranslatorSRI/NodeNormalization/issues/235).