search

TranslatorSRI / NodeNormalization

Service that produces Translator compliant nodes given a curie
MIT License
9 stars 6 forks source link

orphanet prefix case #209

Closed colleenXu closed 7 months ago

colleenXu commented 11 months ago

At some point in 2022/2023, it was clarified that the Orphanet prefix for biolink-model is orphanet (all lower-case).

However, Node Norm returns the Orphanet IDs for diseases as ORPHANET (all upper-case): example in dev.

This causes issues with BTE / Service Provider when we try to switch from ORPHANET -> orphanet to comply with biolink-model. https://github.com/biothings/biothings_explorer/issues/640

I'm wondering if maybe Node Norm can be updated to use the all lower-case orphanet...

Tagging @sierra-moxon just in case.

gaurav commented 7 months ago

I think this has now been implemented in NodeNorm Dev -- see e.g. normalization of MONDO:0017830, which includes orphanet:314911 as an alternate identifier. I'm not seeing any references to Orphanet or ORPHANET identifiers in the latest Babel files. So I'm going to close this, but please reopen it if you see these changes in NodeNorm Dev and (later this month) in NodeNorm Prod.