Figure out why NodeNorm CI does not appear in SmartAPI registration - Githubissues

TranslatorSRI / NodeNormalization

Service that produces Translator compliant nodes given a curie

MIT License

10 stars 6 forks source link

Figure out why NodeNorm CI does not appear in SmartAPI registration #262

Closed gaurav closed 1 month ago

gaurav commented 5 months ago

This means that NodeNorm CI appears in our trapi-openapi record, but not in our SmartAPI record. All other endpoints -- including NodeNorm Dev, which should be identical to NodeNorm CI -- appear in the list of servers without any problem.

We can't get a proper validation error from SmartAPI, because when it tries to access https://trapi-openapi.apps.renci.org/trapi/infores%3Asri-node-normalizer/1.4.0 it fails because this is OpenAPI v3.1.0, while it expects a v3.0.x release. This may have happened when I upgraded FastAPI from 0.83 to 0.108, but note that NodeNorm Dev -- which is very much v3.1.0 -- works fine. So it can't be just that, unless that messed up the OpenAPI file in trapi-openapi somehow.

Possible fixes:

Revert NodeNorm to FastAPI 0.98.0, which is the last version of FastAPI to not support OpenAPI v3.10.0.
Wait for SmartAPI to add support for OpenAPI v3.10.0.
Come up with some way to override the version without changing the schema, which does not seem... great.

gaurav commented 1 month ago

All NodeNorm instances now show up in ARAX (although they are duplicated, see #296). Closing.