search

TranslatorSRI / SRI_testing

MIT License
0 stars 1 forks source link

non_canonical are canonical? #77

Closed cbizon closed 2 years ago

cbizon commented 2 years ago

query_graph.predicate.non_canonical context: Query Graph edge_id: n01--['biolink:subclass_of']->n02 predicate: biolink:subclass_of

This is complaining that subclass_of is non-canonical in biolink 2.2.11. But in that version of biolink, we see this:

    is_a: related to
    description: >-
      holds between two classes where the domain class is a specialization of the range class
    domain: ontology class
    range: ontology class
    multivalued: True
    in_subset:
      - translator_minimal
    annotations:
      tag: biolink:canonical_predicate
      value: true

i.e. it is canonical. I also saw this for has_phenotype

RichardBruskiewich commented 2 years ago

See https://github.com/TranslatorSRI/SRI_testing/issues/55.

This is not really a known tradeoff of the SRI Testing given a non-backwards compatible constraint within the Biolink Model Toolkit (0.8.10++). This defect should disappear when KPs and ARAs upgrade to and validate against 3.0.*.