Open gaurav opened 1 year ago
Hi @gaurav, I've taken a run at resolving your issue above, just now posted into the master branch as commit https://github.com/TranslatorSRI/SRI_testing/commit/e9adc4b92fdfa41c04f58cdc7a3c169cc43485f1. Please kindly remove the updated README.md file.
Thanks, Richard! The updated README file looks good. Are you going to update the poetry run
instructions in tests/onehop/README.md
as well?
Thanks for the feedback.
The project was originally pip installed. The change to poetry does modify the required commands as you indicated. Sorry about the lag in docs. I'll fix this right away.
Thanks, Richard! The updated README file looks good. Are you going to update the
poetry run
instructions intests/onehop/README.md
as well?
AH yes.. good point! I'll do that in a few minutes... just putting out another technical fire...
OK, please see the master again. I've updated the OneHop detailed README now (plus a few refinements elsewhere).
@gaurav please kindly review the final revised documentation. I hope we've gotten there. If you think we have, please close the issue.
This looks great! I have one minor suggestion: after saying "you would type the following from within the tests/onehop project subfolder:", I would change the example code to:
cd tests/onehop
pytest test_onehops.py
Just to make sure nobody misses that. Otherwise, the test commands I tried all worked for me! Feel free to close this issue once you've decided whether or not to incorporate my suggestion above.
The one-hop README contains instructions on running individual tests at https://github.com/TranslatorSRI/SRI_testing/tree/d034e836bca2c7116778abcb9bd356bb5e36cac6/tests/onehop#running-the-tests.
pytest -vv test_onehops.py --kp_id=molepro --ara_id=SKIP
, but I've found this command requires two additional instructions to make it work:tests/onehop/test_onehops.py
pytest
-- to use the Poetrypytest
, the command should be run aspoetry run pytest -vv test_onehops.py --kp_id=molepro --ara_id=SKIP
.