Closed franzbecker closed 6 years ago
Merging #135 into master will increase coverage by
0.93%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #135 +/- ##
===========================================
+ Coverage 58.16% 59.1% +0.93%
Complexity 82 82
===========================================
Files 9 9
Lines 306 313 +7
Branches 24 25 +1
===========================================
+ Hits 178 185 +7
Misses 116 116
Partials 12 12
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
.../transmode/gradle/plugins/docker/DockerTask.groovy | 70.45% <100%> (+4.66%) |
15 <4> (ø) |
:arrow_down: |
...transmode/gradle/plugins/docker/JavaBaseImage.java | 76.92% <100%> (+1.92%) |
3 <0> (ø) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 48636f4...23d4e54. Read the comment docs.
Thanks for the contribution, looks good to me.
even though this pullrequest is merged, no new version was released @bjornmagnusson could you please release a new version?
For anyone stuck with this issue and awaiting a new release, the workaround is to supply a partial Dockerfile that just defines whatever baseImage you're after.
e.g. in your docker task definition:
dockerfile='docker/Dockerfile'
And the contents of that docker/Dockerfile:
FROM openjdk:11-jre
The
DockerTask.getBaseImage()
method is currently not implemented correctly.I had the following setup:
and it still failed with:
This is due to the fact that the base image for the specified Java version is still retrieved (and fails). In this case there is no need to retrieve it as an explicit base image is specified.