search

Transmode / gradle-docker

A Gradle plugin to build Docker images from the build script.
Apache License 2.0
647 stars 142 forks source link

update gradle and add java 10 base image #138

Closed varpa89 closed 6 years ago

HaVonTe1 commented 6 years ago

+1 Thx a lot.

bjornmagnusson commented 6 years ago

Please remove the gradle upgrade from the PR, and rebase your branch. Gradle upgrades affects too much to be in a feature PR. Merged a fix for https://blog.gradle.org/unable-to-download-maven-central-bintray in #140.

codecov-io commented 6 years ago

Codecov Report

Merging #138 into master will increase coverage by 0.13%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #138      +/-   ##
============================================
+ Coverage      59.1%   59.23%   +0.13%     
  Complexity       82       82              
============================================
  Files             9        9              
  Lines           313      314       +1     
  Branches         25       25              
============================================
+ Hits            185      186       +1     
  Misses          116      116              
  Partials         12       12
Impacted Files Coverage Δ Complexity Δ
...transmode/gradle/plugins/docker/JavaBaseImage.java 78.57% <100%> (+1.64%) 3 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 32cb8f2...30735e1. Read the comment docs.

varpa89 commented 6 years ago

Ok! I'll do another clean PR.

varpa89 commented 6 years ago

here is https://github.com/Transmode/gradle-docker/pull/141