search

Transmode / gradle-docker

A Gradle plugin to build Docker images from the build script.
Apache License 2.0
647 stars 142 forks source link

Publish action does not support private repositories #24

Closed sgoings closed 10 years ago

sgoings commented 10 years ago

It looks like the Docker push action doesn't support private (or specified) repositories:

https://github.com/Transmode/gradle-docker/blob/master/src/main/groovy/se/transmode/gradle/plugins/docker/client/NativeDockerClient.groovy#L40 shows that the push command only pushes the docker tag (with no additional options).

sgoings commented 10 years ago

Ooops!

I had a few problems:

docker {
  registry = https://docker.example.com // obviously not example.com
  // should be
  registry = docker.example.com
}
task dockerContainer(type: Docker}
  tag = "group/some-component"
  // should have been
  tag = "${docker.registry}/group/some-component"
}