Display docker command line output. This also ensures the process output...

Transmode / gradle-docker

A Gradle plugin to build Docker images from the build script.

Apache License 2.0

647 stars 142 forks source link

Display docker command line output. This also ensures the process output... #25

Open skullmaggots opened 10 years ago

skullmaggots commented 10 years ago

Changes to the DockerNativeClient so that the process buffer does not get full and hang the process.waitFor() blocking call for large docker builds. It also shows the progress of the docker build during its execution.

skullmaggots commented 10 years ago

Added another minor change to this pull request to use ant copy task instead of built in copy. This is done so only files that have been modified are copied across from gradle build dir to docker stage if they have changed. Doing this means you will get full use of docker cache on ADD command, which also means subsequent docker commands after that will also get benefit of the cache.

sgoings commented 10 years ago

Sweet! I've been wanting to see this!

Any reason why you used ant's copy instead of the Sync task in Gradle? (or why you didn't wire up the inputs/outputs for a copy task such that Gradle won't copy the file if it doesn't need to?)

sgoings commented 10 years ago

Note: provides a fix for #26...

skullmaggots commented 10 years ago

No technical reason - just looking for something other than gradle copy task which always copies the file whether it has changed or not.

sgoings commented 10 years ago

Part of the problem is that it was using the copy command in Gradle, not the full-fledged copy task, where the latter doesn't know about inputs/outputs so it doesn't benefit from any up-to-date checks. (see: http://www.gradle.org/docs/current/userguide/working_with_files.html#copy)

sfitts commented 10 years ago

I agree that what we probably want to do is fully wire this to Gradle's task inputs/outputs, but my sense right now is that's a bit more work (see #20 for some related issues). For now I think avoiding the copy when not necessary is a good step. I'll do a quick sanity check and then merge to dev.

sfitts commented 10 years ago

Unfortunately I'm seeing a failure in one of the tests -- testAddFileWithDir. I think the ant copy task has an issue copying directories. The error I see is:

: Use a resource collection to copy directories.
    at org.apache.tools.ant.taskdefs.Copy.validateAttributes(Copy.java:684)
    at org.apache.tools.ant.taskdefs.Copy.execute(Copy.java:442)

sfitts commented 10 years ago

FYI -- I swiped the first part of this (to display the output as we go) and included it in my recent commit to dev.

magnus-larsson commented 9 years ago

Any plans to make a release with this issue resolved? We are kind of blocked on issue #37 "docker build task is hanging" and I guess that the code committed to dev as described above solves this issue.

Regards, Magnus.

marcoivich commented 9 years ago

I am running into this issue in Windows. Any updates into when this fix will be released?

Thank you,

Marco

davidresnick commented 8 years ago

We're also having this problem - on Windows systems, the build hangs. We still have a lot of developers working on Windows laptops, and will for the foreseeable future. Any update on when the fix will be included in a release?