search

TransparentHealth / smh_app

Share My Health App: An application for Community Members and Community Based Organizations
Apache License 2.0
2 stars 3 forks source link

Member subject_url #126

Closed sharrisoncaktus closed 5 years ago

sharrisoncaktus commented 5 years ago

https://github.com/TransparentHealth/smh_app/issues/80

The Member subject_url is displayed on the "Basic Information" page (member:member-update).

Rather than rewriting too much code, I opted to follow @aviars suggestion to keep the pk-based URLs in place. The new member:subject_url just redirects to the corresponding member url. The downside of this is that the pk is still on display in the browser address bar. The upside is that a lot of code didn't have to be rewritten! We can take the next step if and when it becomes clear that the subject url should be displayed in the address bar and used as the "primary" URL space.

aviars commented 5 years ago

@seanharrison I merged each PR and had conflicts on the last. I have already approved. Can you please resolve conflicts and merge to master?