search

Transport-for-the-North / caf.base

Core classes and definitions for CAF family of tools
GNU General Public License v3.0
0 stars 1 forks source link

SIC/SOC exclusions / inclusions need expanding #48

Open simonkilbyaecom opened 2 months ago

simonkilbyaecom commented 2 months ago

The combinations between SIC 1 digit and SOC need expanding. At the moment only (-1,4) is permitted. However, it should also allow 1,...,21 to map to each of 1,2,3. Similarly for SIC 2 digit for 1,...99.

@isaac-tfn if you agree then I've attached files that should fix this. In yaml format but saved as txts as github didn't like yamls here.

There is potentially a separate discussion down the road about sic_4_digit and if we also need a -1 category there. sic_2_digit.txt sic_1_digit.txt

isaac-tfn commented 2 months ago

Hi Simon, thanks yes you're right, oversight on my part. Thanks for fixing in those files I'll check them and add them now. If I'm right that sic_4 will never occur on its own with soc, then I'll leave that one out for now, but let me know if it does occur on its own anywhere and I'll add them for that too.

isaac-tfn commented 2 months ago

@simonkilbyaecom they should be working now, sorry again about that. I've also added in correspondences of -1 to -1 between the different sic segments, seems to be working now.