Tweaks to coding in line with Land-Use requirements

asongtoruin commented 4 months ago

Hi! As part of our work on Land-Use we've made a couple of quick changes to the code to get it working nicely for us, namely:

Allowing non-integer Zone IDs. As we're using Census data mostly, being able to use the Census codes directly would be very helpful for us. For the time being we've just commented out the integer checks and added a TODO comment - hopefully this fits with your workflow!
Some of the DVector checks use equal_levels - this only applies when the DataFrame has a MultiIndex - i.e. multiple levels of segmentation. In our case, we may sometimes only have a single level of segmentation, so the code was crashing. This fix is a fairly simple one that just chooses the method based on the index type

Not sure how well this will integrate with your existing tests, apologies, but hopefully this gives you a good starting point for accommodating these changes!

asongtoruin commented 4 months ago

@isaac-tfn thanks for merging in your changes too! Spotted a snag that I've (hopefully!) just fixed now as well.

MattBuckley-TfN commented 2 months ago

The pandas_2 branch was merged with main and deleted this morning so this PR was automatically closed.

@asongtoruin - Please can you switch this PR to be merged with the main branch and reopen it.

Transport-for-the-North / caf.core

Tweaks to coding in line with Land-Use requirements #23