Transport-for-the-North / caf.core

Core classes and definitions for CAF family of tools
GNU General Public License v3.0
0 stars 1 forks source link

Possibly inconsistency between SOC exclusions and observed #40

Open asongtoruin opened 1 month ago

asongtoruin commented 1 month ago

ONS Table 3 gives us a category of "Economically active (excluding full-time students): Unemployed". We have interpreted that as:

However, soc 4 has an Exclusion listed with economic_status 2 (line 28 in this snippet):

https://github.com/Transport-for-the-North/caf.core/blob/a47c8b01bd5b2d88f3a2aebe684a4bca41186eff/src/caf/core/segments/soc.yml#L8-L29

Should this exclusion exist? Feels like it shouldn't to me.

MatteoGravelluTfN commented 1 month ago

Hi @asongtoruin, you are correct.

SOC4 should have the exclusion with economic_status=1 (econ. active employed) and economic_status=3 (econ. active employed student only), so 2 needs to be removed from the exclusion.

asongtoruin commented 1 month ago

Can this be actioned, ideally in the IPF branch? I don't think we have the ability to edit caf.core in place so it would need to be someone on TfN's side

MatteoGravelluTfN commented 1 month ago

Changed in IPF branch. Please let me know if any other changes are required.

MatteoGravelluTfN commented 1 month ago

@asongtoruin are you using at all in the in the model the aws.yml yet? Just checking as I believe Isaac used it but there might be some issues there that I've just detected.

asongtoruin commented 1 month ago

We might need to move the discussion away from this issue (as it's possibly unconnected) but no, to my knowledge the aws segment is just being used in the post-processing