search

Transport-for-the-North / caf.space

https://cafspace.readthedocs.io/en/stable/
Other
2 stars 2 forks source link

Refactor #1

Closed isaac-tfn closed 1 year ago

isaac-tfn commented 1 year ago

PR for review of testing and geo-utils rewrite. Only 'test_zone_translation.py' has working tests so any other test files can be ignores.

BenTaylor-TfN commented 1 year ago

After a bit of a headache I've tidied up the requirements.txt file.

I removed strictyaml as it'll be installed by caf.toolkit anyway, and it's not used directly. I've also moved caf.toolkit to the top of the import list as conda was insistent on only installing caf.toolkit==0.0.4 when geopandas came before it.

I'd recommend removing the requirements.txt in docs too so there is one less place of repeated requirements that we need to maintain.

codecov[bot] commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@eba8ae3). Click here to learn what that means. Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1 +/- ## ======================================= Coverage ? 84.79% ======================================= Files ? 6 Lines ? 296 Branches ? 0 ======================================= Hits ? 251 Misses ? 45 Partials ? 0 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Transport-for-the-North). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Transport-for-the-North)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.