Transport-for-the-North / caf.space

https://cafspace.readthedocs.io/en/stable/
Other
2 stars 2 forks source link

UI #5

Closed isaac-tfn closed 1 year ago

isaac-tfn commented 1 year ago

Describe Changes

Task Checklist

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 26.04% and project coverage change: -28.89 :warning:

Comparison is base (c3f3acd) 85.88% compared to head (e60d8a3) 57.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #5 +/- ## =========================================== - Coverage 85.88% 57.00% -28.89% =========================================== Files 6 7 +1 Lines 326 600 +274 =========================================== + Hits 280 342 +62 - Misses 46 258 +212 ``` | [Impacted Files](https://codecov.io/gh/Transport-for-the-North/caf.space/pull/5?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Transport-for-the-North) | Coverage Δ | | |---|---|---| | [src/caf/space/ui.py](https://codecov.io/gh/Transport-for-the-North/caf.space/pull/5?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Transport-for-the-North#diff-c3JjL2NhZi9zcGFjZS91aS5weQ==) | `22.05% <22.05%> (ø)` | | | [src/caf/space/inputs.py](https://codecov.io/gh/Transport-for-the-North/caf.space/pull/5?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Transport-for-the-North#diff-c3JjL2NhZi9zcGFjZS9pbnB1dHMucHk=) | `82.85% <90.90%> (+0.24%)` | :arrow_up: | | [src/caf/space/\_\_init\_\_.py](https://codecov.io/gh/Transport-for-the-North/caf.space/pull/5?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Transport-for-the-North#diff-c3JjL2NhZi9zcGFjZS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | | | [src/caf/space/zone\_translation.py](https://codecov.io/gh/Transport-for-the-North/caf.space/pull/5?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Transport-for-the-North#diff-c3JjL2NhZi9zcGFjZS96b25lX3RyYW5zbGF0aW9uLnB5) | `89.15% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Transport-for-the-North). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Transport-for-the-North)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

isaac-tfn commented 1 year ago

Codecov isn't passing as the UI module is currently untested - should add testing in the future but the UI module isn't that widely used at the moment.