Closed wsp-mbuckley closed 1 week ago
Please can you link to the functions / code you're referring to here to make it clearer?
The generic translation function (pandas_vector_zone_translation
) should contain the inferring / warning for the unique index parameters, as this wraps the other 2 functions. The other 2 functions should have the index parameters be mandatory, as people are more likely to use the wrapper function anyway.
pandas_vector_zone_translation
should allow for the parameters to be optional and infer them from the translation file but should also warn if inferring them.pandas_single_vector_zone_translation
should stick with requiring the 2 parameters, this is called by the above function anyway if people need the inferring or they could do it themselves.pandas_multi_vector_zone_translation
should also use the 2 parameters so it can do the same validation checks as the single vector function, again these probably want to be mandatory for this function.fixed in #117
The
from_unique_index
andto_unique_index
parameters can be inferred from the data so the parameters should be optional. However, a warning should be raised as it is preferred to include the parameters for sense checks of the translation process and infilling.