TrashMonks / qud-wiki

Desktop app for creating and updating the official Caves of Qud wiki
https://wiki.cavesofqud.com/
GNU Affero General Public License v3.0
11 stars 3 forks source link

Image upload for "Advertisment" #63

Closed egocarib closed 2 years ago

egocarib commented 2 years ago

For some reason, "MerchantAdvertisement" image seems to upload as a weird/empty image: https://wiki.cavesofqud.com/wiki/File:Advertisement_for_legendary_merchant.png

Not sure why this is, but crypto shows this tile fine, so I'm guessing it's something we're doing strange in the QBE upload process?

syntaxaire commented 2 years ago

This was being adblocked, which is very amusing to me. Made an override to call this tile "scroll for legendary merchant" instead and uploaded.

egocarib commented 2 years ago

Seems to have re-surfaced; investigate whether override is still working / re-implement. LOL.

Wreckstation commented 2 years ago

For pages that use overrideimages for variations, the names are taken from self.tiles_and_metadata()'s filename, not image overrides from config. Not sure where this is defined and this is like a weird corner case that for now we can just manually rename. it probably won't be changing anytime soon

egocarib commented 2 years ago

I think this actually works from what I'm seeing. self.tiles_and_metadata ultimately pulls from QudObject.image. Since QBE uses the QudObject subclass QudObjectWiki, which has its own version of def image that pulls from the config, the alternate tiles use the config override too. In this example, I pulled your change to config which changes the name to "scroll..." and all the override images are based on that name too.

image