search

Traumflug / Teacup_Firmware

Firmware for RepRap and other 3D printers
http://forums.reprap.org/read.php?147
GNU General Public License v2.0
312 stars 199 forks source link

gcode_parse.c: spacing and S debugging #87

Open drf5n opened 10 years ago

drf5n commented 10 years ago

Raising the word size for S should probably use a serwrite_int32() for the debugging.

https://github.com/Traumflug/Teacup_Firmware/blob/experimental/gcode_parse.c#L176

Also, maybe the uint/int parts should be checked for the others, for instance a retraction E-1.0 would look ugly as a uint32

There's also a bunch of spacing changes that were introduced with the looping patch, but I didn't try fixing thse because my editor's spacing isn't set up well.

What's proper indenting coding style for teacup? Tabs for indenting + spaces for alignment?

Traumflug commented 10 years ago

Raising the word size for S should probably use a serwrite_int32() for the debugging.

Yes, well spotted. Feel free to put such a commit onto master.

What's proper indenting coding style for teacup?

Historically it was all tabs and the future should be all spaces. Accordingly I usually use spaces in new or changed code and keep what's in unchanged lines. Just converting everything isn't exactly simple, because some Git commands can't ignore space changes.

Stuff aligns nicely if you set tabs to size 2.

Traumflug commented 10 years ago

Also, maybe the uint/int parts should be checked for the others, for instance a retraction E-1.0 would look ugly as a uint32

Yes as well.

I have to admit I never use these debug flags. Instead I insert sersendf()'s in suspicious places depending on what I'm trying to find out. A recompile & upload is just 10 seconds, after all.

drf5n commented 10 years ago

I fiddled with my editor a bit and set up a default tab size for the whole directory and some smarter indenting settings. Looks lots nicer than the old tabsize=8 I was seeing.

I just pushed an issue87 branch with these issues corrected.

I noticed these because I had made the S word size change on my local branch and it still needed the E and S debug bits.

Traumflug commented 9 years ago

During kind of a spring cleaning I found this issue87 branch, rebased it to current experimental and picked the one line code change remaining to there.

This issue should be solved. Thank you very much for the effort.