TravaOpenJDK / trava-jdk-11-dcevm

dcevm-11 built on Travis
Apache License 2.0
403 stars 56 forks source link

Is this a dcevm binary packaging issue? #2

Open espre05 opened 5 years ago

espre05 commented 5 years ago

I expected the macos binary to create a "decevm-xxx.jdk" directory on expanding.

However it created a "package" file as in screenshot. I had to append .gz to it, and untar again. Could this be avoided?

I can make the change, if you give me some pointers on where in this codebase I need to look.

Source: https://github.com/TravaOpenJDK/trava-jdk-11-dcevm/releases/download/dcevm-11.0.1%2B4/java11-openjdk-dcevm-osx.tar.gz

Screenshot showing package file, adding .gz, resulting .cpgz , then able to expand:

image

skybber commented 5 years ago

We're using clone of AdoptOpenJDK scripts https://github.com/TravaOpenJDK/openjdk-build . Archive is done at https://github.com/TravaOpenJDK/openjdk-build/blob/master/sbin/common/common.sh#L84 . This package can look overwhelming, but it is not so. The entry point is makejdk-any-platform.sh and the rest of important scripts are at sbin. If you want really do this, then

isn't it exciting ?

stephanrauh commented 5 years ago

Same problem here (with Dcevm-11.0.1+8 or 2019-03-30). I was very confused by getting a "package". Truth to tell, I know you, @skybber, do great stuff, so I continued Googling until I saw this ticket which gave me a cue what to do.

Would you mind to add a step-by-step walkthrough to http://hotswapagent.org/mydoc_quickstart-jdk11.html for Mac users?

Thanks in advance, Stephan

P.S: My first, quick tests after successfully installing your new build of DCEVM look promising. It's much more simple than in the Java 8 age. Thanks a lot for making things easy! I'm looking forward to a thorough test.

CU Stephan

skybber commented 5 years ago

It would be great if you can help us with it. You can contact me by email. Thanks.