TravaOpenJDK / trava-jdk-8-dcevm

dcevm-8 built on Travis (under construction)
Apache License 2.0
61 stars 42 forks source link

Windows Build - error RC2104 : undefined keyword or key name: dcevm8u282b08 #4

Open phiberber opened 3 years ago

phiberber commented 3 years ago

[Issue]

Error code: C:\Users\travis\build\phiberber\trava-jdk-8-dcevm\openjdk-build\workspace\build\src\hotspot\src\os\windows\vm\version.rc(41) : error RC2104 : undefined keyword or key name: dcevm8u282b08

Description: I've seen you tried to solve this issue two years ago (latest commit on that file), even though you didn't manage yet to build a Windows version for it, I would love to help with it but it would take days to get used to the code (even more as it's full of redirects and git clones) & I have a personal job that takes my whole day almost. Couldn't find where that issue was from as Github Search didn't work that well on the project. @skybber, I know you've been working more on czsky but would help me a lot if you could give attention to this issue as I can't use Open JDK 11 for my project.

Useful Information:

My fork of the repository Travis CI Logging

skybber commented 3 years ago

Hi, I think that only way is to use VS 2010 toolchain

https://github.com/TravaOpenJDK/trava-jdk-8-dcevm/blob/master/build_windows.sh#L17

but I did not resolve how to do it. The build scripts is based on AdoptOpenJDK scripts, they resolved this issue in the past, pby they are using 2010 toolchain. may be you can ask on adopt slack. Unfortunately I don't have enough time for it now.

phiberber commented 3 years ago

I'm already using 2010 Toolchain as I saw, didn't know that issue was caused by AdoptOpenJDK, will try to contact them asking for the solution. I'll come back and tell you if I get it, don't want to spend that much time on it though, as I have things to deliver this week. Thanks for responding, didn't think you would.

phiberber commented 3 years ago

Are you sure that the problem is with AdoptOpenJDK? I didn't find the directory workspace / hotspot on their Github.

skybber commented 3 years ago

Problem is in toolchain, they are building jdk8 with the same script as Trava-jdk8 does.

cagriuzel commented 3 years ago

Hi, I also try to build windows version of dcevm8u282b08 but no luck yet. @phiberber , @skybber any update here ?

skybber commented 3 years ago

Unfortunatelly no updates.

phiberber commented 3 years ago

I adapted my code so it could run in the TravaJDK 11. Was not as hard as I thought it would be.

Didn't figure out how the problem was in the toolchain as AdoptOpenJDK is able to compile using it.

cagriuzel commented 3 years ago

I finally manage to build dcevm8u282b08 branch successfully (hotspot only) in my local pc. But I cant build dcevm8u282b08 branch with jfr enable. jvm.dll enough for me to use dcevm.

1) configure --disable-ccache --with-freetype-include=/cygdrive/d/freetype-2.9.1/include --with-freetype-lib=/cygdrive/d/freetype-2.9.1/win64 --with-target-bits=64 --with-boot-jdk=/cygdrive/c/Java/jdk1.7.0_80 --enable-jfr=no 2) make hotspot

skybber commented 3 years ago

I'm migrating TravaOpenJDK from Travis to Github actions now since Travis started to restrict free builds :( . It is already done in https://github.com/TravaOpenJDK/trava-jdk-11-dcevm/actions/workflows/manually.yml .

phiberber commented 3 years ago

I finally manage to build dcevm8u282b08 branch successfully (hotspot only) in my local pc. But I cant build dcevm8u282b08 branch with jfr enable. jvm.dll enough for me to use dcevm.

  • Windows SDK for Windows 7.1
  • Cygwin64
  • freetype
  • jdk1.7.0_80
  1. configure --disable-ccache --with-freetype-include=/cygdrive/d/freetype-2.9.1/include --with-freetype-lib=/cygdrive/d/freetype-2.9.1/win64 --with-target-bits=64 --with-boot-jdk=/cygdrive/c/Java/jdk1.7.0_80 --enable-jfr=no
  2. make hotspot

Is Windows 7.1 SDK really required? I remember it having a lot of compatibility issues with Windows 8 and 10.