search

TravelMapping / EduTools

Educational tools using TravelMapping data
3 stars 21 forks source link

HDX: hidden labels in graphs #315

Open yakra opened 4 years ago

yakra commented 4 years ago

From https://github.com/TravelMapping/DataProcessing/issues/282#issuecomment-724195735

The HDX appears to treat a label with a + anywhere in it as a hidden label.

VISIBLE_HIDDEN_COLOC and HIDDEN_JUNCTION cases are flagged as visible in the in-memory representation of the graph structure in siteupdate, and accordingly make into the collapsed graphs. In the HDX, their markers are hidden even when Show Markers is selected, so there's nothing to click on if we want to view their info.

IMO, always hiding these vertices' markers provides very little benefit for collapsed graphs, as 99.4-99.95% of these vertices are already collapsed away into edges.

Conversely, if someone goes to the trouble of loading a simple instead of collapsed graph, they're probably interested in seeing the info for the points that would otherwise be collapsed.

I propose losing the visible/hidden distinction based on + in labels, and just showing/hiding everything based on Show Markers.

If this would conflict with functionality we might want for other non-.tmg formats, how hard would it be to implement for .tmg only?

jteresco commented 4 years ago

Again, without thinking it through too much, the first thing I come up with is the situation where one might wish to load a simple graph and be able to toggle on and off the hidden points to see/demonstrate the role of shaping points in defining our routes.

jteresco commented 2 years ago

The HDX appears to treat a label with a + anywhere in it as a hidden label.

Is a quick fix to treat as hidden only waypoint labels that start with a +? I think those are the only ones we might want to hide when loading a non-TMG format file. For TMG files, it seems we would want to show all waypoint labels, and we would gain this functionality by changing to a + at the start only, since no graph waypoint label begins with a +.

yakra commented 2 years ago

IIUC this might be a fix, yes. Hiding waypoints specifically, rather than vertices.

What are your thoughts WRT hidden points in simple graphs? One potential option: if a vertex is flagged as hidden (ie, all colocated points are hidden), add a leading +

jteresco commented 2 years ago

What are your thoughts WRT hidden points in simple graphs?

I'm thinking that if you're using a simple rather than collapsed format graph, you probably want to see the shaping points as vertices as much as you would any other. (yes, contradicting my statement above from a couple years ago)

yakra commented 2 years ago

So the simplest thing to do would be to keep current Foo@+Bar&Baz@+Qux, Foo/Bar@+Baz etc formats.