search

TravelMapping / Web

Web-facing tool/page development
8 stars 26 forks source link

LABEL_TOO_LONG #408

Closed yakra closed 4 years ago

yakra commented 4 years ago

I never added a check to suppress FP codes for LABEL_TOO_LONG errors. https://github.com/TravelMapping/DataProcessing/pull/305 https://github.com/TravelMapping/DataProcessing/issues/56#issuecomment-607477949 Rather than just add another strcmp line, https://github.com/TravelMapping/Web/blob/2faf5a37d530caaf748bfaa87b36e5aff15754c5/devel/datacheck.php#L72-L92 can be redone for optimal efficiency.

yakra commented 4 years ago 
mysql> select code, count(code) from datacheckErrors group by code order by count(code) desc;
+----------------------+-------------+
| code                 | count(code) |
+----------------------+-------------+
| VISIBLE_DISTANCE     |        9939 |
| SHARP_ANGLE          |        2649 |
| LABEL_SELFREF        |        1424 |
| LABEL_LOOKS_HIDDEN   |         412 |
| DUPLICATE_COORDS     |         294 |
| LONG_SEGMENT         |         256 |
| LONG_UNDERSCORE      |          69 |
| VISIBLE_HIDDEN_COLOC |          68 |
| DUPLICATE_LABEL      |          62 |
| HIDDEN_JUNCTION      |          31 |
| LABEL_INVALID_CHAR   |           4 |
| INVALID_FINAL_CHAR   |           3 |
| LABEL_SLASHES        |           2 |
| BAD_ANGLE            |           2 |
| HIDDEN_TERMINUS      |           1 |
+----------------------+-------------+
15 rows in set (0.04 sec)
yakra commented 4 years ago

The fastest solution is to rule out "fp_possible" codes, in descending order of frequency.