search

TravelMapping / Web

Web-facing tool/page development
8 stars 26 forks source link

No FP entries for CONRTE_COORD_MISMATCH datacheck error #455

Closed michihdeu closed 4 years ago

michihdeu commented 4 years ago

datacheck.php should not provide FP entries for CONRTE_COORD_MISMATCH datacheck errors.

https://github.com/TravelMapping/DataProcessing/issues/337

yakra commented 4 years ago

451 already has this covered.

michihdeu commented 4 years ago

No, it doesn't! Just the LABEL_TOO_LONG!

yakra commented 4 years ago

It does in fact have this covered: It checks whether a given error code is not a member of the list of codes for which FPs are allowed. CONRTE_COORD_MISMATCH is not and will not be on that list. https://github.com/TravelMapping/Web/pull/451/files

yakra commented 4 years ago

Oops - I see that LABEL_TOO_LONG was erroneously included on the list where FPs are allowed. Will remove.

michihdeu commented 4 years ago

Oops - I see that LABEL_TOO_LONG was erroneously included on the list where FPs are allowed. Will remove.

😃 yep, that's why I was confused. I read it again and again now and was about to ask why the hell FPs for LABEL_TOO_LONG should be allowed!

But the manual was changed correct. I just got the code wrong 😄

yakra commented 4 years ago

https://github.com/TravelMapping/Web/commit/466b7db440abc75f6cd7af185759e2724f5386e9