search

TravelMapping / Web

Web-facing tool/page development
8 stars 26 forks source link

Incorrect shields and links on clinched.php #583

Closed jteresco closed 3 years ago

jteresco commented 3 years ago

https://forum.travelmapping.net/index.php?topic=4039.msg21723;topicseen#msg21723

jteresco commented 3 years ago

Now thinking it might be a data processing problem. Creating https://github.com/TravelMapping/DataProcessing/issues/400 but will leave this open for now as well in case there's a problem with the clinched.php query.

jteresco commented 3 years ago

So following on what I just put into https://github.com/TravelMapping/DataProcessing/issues/400 the problem here is that when you are looking at a connected route, the shield generated would come from the first root in the connected route. In the problematic case here, that's in LAO, even though the travels on that connected route are only in KHM.

jteresco commented 3 years ago

The fact that the shield generated has the LAO in it is misleading. It's not an LAO route, it's an "UNESCAP / ASEAN Asian Highways (for review)" route in the international system asiahr. We don't see this in many systems like usai, usaus, and eure, since the state or country name isn't put into the generated shield.

jteresco commented 3 years ago

So the fix here is in part with the shield generator for cases where we don't have a template and it uses the region name above the route name in a generic square with rounded corners.

jteresco commented 3 years ago

The easier fix, which I am about to try out, is to add the &cr to the URL linked for each, as the clinched.php page deals with connected routes, not chopped routes.

jteresco commented 3 years ago

The &cr fix is live on the main site. What to do about the misleading region name in the shields remains to be determined.

jteresco commented 3 years ago

Idea: create a simple "plain" set of shield templates for routes that span multiple regions and don't otherwise have a nice shield like usai, usaus, eure, etc. In this case, it might make sense to have the "AH" instead of the region name on the top, and only the route number below.

Unfortunately, I don't think the primary author of the shield generator checks in on the project much. Any volunteers?

michihdeu commented 3 years ago

Is this a duplicate of #121? Or related?

jteresco commented 3 years ago

Is this a duplicate of #121? Or related?

Definitely related, but I'd say a separate problem.

jteresco commented 3 years ago

With the recent progress on shield generation and the improvements to clinched.php, I'm going to go ahead and close this.