datacheck.php hidden system support

TravelMapping / Web

Web-facing tool/page development

8 stars 26 forks source link

datacheck.php hidden system support #801

Open yakra opened 1 month ago

yakra commented 1 month ago

Preliminary support for hidden systems is on tmtest for the moment: https://tmtest.teresco.org/devel/datacheck.php?show=COMBINE_CON_ROUTES

System & Region filtering are broken, most likely due to trying to JOIN on a route not in the DB.

Would have to either

add hidden system info to the DB, which I'm not thrilled about, or
add new columns to the datacheckErrors tabke for system & region. I like this better

michihdeu commented 1 month ago

The first showroute link at COMBINE_CON_ROUTES for hidden systems is missing. It's fine for preview and devel. Dunno about active. @yakra

yakra commented 1 month ago

I know, noted over here.

This problem is not actually that the 1st one is missing, but that the 2nd one was still there. Neither should be there for hidden systems, which don't go in the DB at all.

If you still have the page open (it's been updated) and you still have a link in the Info column for a hidden route, click on it and you'll get a broken showroute page.

yakra commented 1 month ago

Note: datacheck with hidden systems isn't on tmtest anymore, so ignore the links in the OP. This still needs to be fixed before going live though.