search

TravelSizedLions / journey

Journey of the Return - Face your demons in this game about death, repentance, and robots.
1 stars 0 forks source link

[B0][5] Quests are completely borked! #202

Closed jaredstorm closed 1 year ago

jaredstorm commented 1 year ago

It looks like all the quest prerequisites are busted... In the lower level of the ship, after talking to any quest giver, the room moves to its post-crash settings...

We'll want to do a git bisect for this beautiful mess.

jaredstorm commented 1 year ago

It's due to the Variable.cs changes in this commit: https://github.com/TheHumanBuilders/journey/commit/259eaca6ed47bb2683b2fc11faab7cf3b3092775

Notes:

  1. Thinking back, I don't know if I ever added prerequisites to the quests, but I'll have to dig into it.
  2. The one quest I see that does have pre-reqs, 0_jerrod, expects boss-shame-beaten to be true before clearing, but that isn't getting respected.
  3. Oh wait, on second thought, it looks like boss-shame-beaten just had its default value set to True. I guess I'd been digging into the issue with Variable defaults not getting set and had used that to test, but it wasn't ever set back.
  4. I also guess I never fixed/tested that default setting issue either, since obviously the code I wrote for it was completely broken. Man, I've really got to stop coding so late into the night.