Closed dependabot[bot] closed 4 months ago
I was just trying this out, and on main
:
Downsample `square_test.png` using resize
time: [38.255 ms 38.270 ms 38.287 ms]
Found 5 outliers among 100 measurements (5.00%)
2 (2.00%) high mild
3 (3.00%) high severe
Besides dropping a massive dependency stack with fallible_collections
, they now added rayon
and are pretty much cheating in speed-comparisons:
Downsample `square_test.png` using resize
time: [2.2758 ms 2.2828 ms 2.2902 ms]
change: [-94.053% -94.035% -94.016%] (p = 0.00 < 0.05)
Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
5 (5.00%) high mild
We'd have to see how this pans out in debug
mode, as the primary reason for us to have ispc-downsampler
was to significantly our debug times.
debug
benchmarks on top of #38:
$ cargo bench --features=ispc --profile=dev
Downsample `square_test.png` using ispc_downsampler
time: [30.624 ms 30.663 ms 30.701 ms]
Benchmarking Downsample `square_test.png` using resize: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 98.8s, or reduce sample count to 10.
Downsample `square_test.png` using resize
time: [986.57 ms 988.70 ms 991.06 ms]
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mild
With this change on top:
$ cargo bench --features=ispc --profile=dev
Downsample `square_test.png` using resize
time: [34.014 ms 34.269 ms 34.526 ms]
change: [-96.561% -96.534% -96.507%] (p = 0.00 < 0.05)
Performance has improved.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild
Of course in our codebase we optimize all our dependencies for size, but run in the dev
profile:
[profile.dev.package.'*']
opt-level = 's'
debug = true
And with that we're on-par with ispc-downsampler
still:
$ cargo bench --features=ispc --profile=dev
Downsample `square_test.png` using resize
time: [31.312 ms 31.564 ms 31.823 ms]
change: [-8.8797% -7.8917% -6.8761%] (p = 0.00 < 0.05)
Performance has improved.
@dependabot rebase and merge
@dependabot rebase
Updates the requirements on resize to permit the latest version.
Commits
You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show