search

Traverse-Research / ispc-downsampler

Image downsampler using a Lanczos filter implemented in ISPC
Other
11 stars 1 forks source link

🪟 Add aarch64 windows build #40

Closed Jasper-Bekkers closed 9 months ago

Jasper-Bekkers commented 9 months ago

Compiled with ispc 1.20 because ispc 1.22 ran into an internal compiler error (reported here: https://github.com/ispc/ispc/issues/2713)

MarijnS95 commented 9 months ago

Can we add this to the CI (instead)?

MarijnS95 commented 9 months ago

Let's see: https://github.com/Traverse-Research/ispc-downsampler/actions/runs/7053442964

MarijnS95 commented 9 months ago

thread 'main' panicked at C:\Users\runneradmin.cargo\registry\src\index.crates.io-6f17d22bba15001f\ispc_compile-2.0.0\src\lib.rs:437:14: Failed to find lib.exe for MSVC toolchain, aborting

@Jasper-Bekkers what do contributors and the CI need to install (on Windows) to be able to cross-compile the ISPC binary for this target when making changes to the ISPC files?

MarijnS95 commented 9 months ago

Or was this all installed (Visual Studio Installer) and performed natively on the machine? I'm not sure how easy it would be to invoke that tool to add the aarch64 toolchain in the CI...

But I recall seeing such a setup in win32metadata which we could borrow.

Jasper-Bekkers commented 9 months ago

I think just a recent version of VS with support for arm64. I ran this from the Developer Commandline that ships with VS2022.

Jasper-Bekkers commented 9 months ago

I would wager a guess that GitHub doesn't have that toolchain installed (yet).

MarijnS95 commented 9 months ago

Were you building natively on the device? Then it makes obvious sense that you can build for the target.

Alas, expect this file to get out of date if you don't add the CI for it :(

Jasper-Bekkers commented 9 months ago

No I was cross compiling.

I'd love to see CI for it, but it looked like the CI step you tried didn't work, right?

MarijnS95 commented 9 months ago

I've got a fix: https://github.com/Twinklebear/ispc-rs/pull/28

Haven't really checked why the 5-year-old gcc crate was finding lib.exe for @Jasper-Bekkers but it doesn't really matter since our CI process does now too! https://github.com/Traverse-Research/ispc-downsampler/actions/runs/7089720459/job/19295068304