search

Traverse-Research / ispc-downsampler

Image downsampler using a Lanczos filter implemented in ISPC
Other
11 stars 1 forks source link

Fix generate binaries action after upload-artifacts bump #44

Closed KYovchevski closed 7 months ago

KYovchevski commented 7 months ago

Dependabot bumped upload-artifacts from v3 to v4 which has a breaking change that artifacts with the same name can no longer be uploaded. As a result, the generate binaries action would need to be run 3 times to generate all the binaries, which is annoying.

The only fix outlined for this change is to upload different named artifacts. An alternative thing we can do is to do download the artifacts at the end and zip them together.

MarijnS95 commented 6 months ago

Oh that's sad and I hope there's a way to back out of that. The entire advantage was that we could build one downloadable artifact from multiple individual jobs :slightly_smiling_face:

Good find though :)

EDIT: Reading https://github.com/actions/upload-artifact?tab=readme-ov-file#not-uploading-to-the-same-artifact, this is intentional and there's no way to go back to the old behaviour.