search

Traverse-Research / ispc-downsampler

Image downsampler using a Lanczos filter implemented in ISPC
Other
11 stars 1 forks source link

Release 0.4.0 #55

Closed KYovchevski closed 3 months ago

MarijnS95 commented 3 months ago

Should we also fix https://github.com/Traverse-Research/ispc-downsampler/pull/54#pullrequestreview-2104445560?

KYovchevski commented 3 months ago

Would've been nice to have had that review in the past week that it was open, and not right after it was merged. I am being put on a different project starting Monday and this was my last chance to wrap this up.

KYovchevski commented 3 months ago

https://github.com/Traverse-Research/ispc-downsampler/pull/56

MarijnS95 commented 3 months ago

Would've been nice to have had that review in the past week that it was open, and not right after it was merged.

A merge is a nice way to bump an MR to the top of my notification/TODO list, and hence get it looked at.

I also don't know how to solve this better going forward other than better educating the team (on both writer and reviewer side) to learn about the ins and outs of doc-comments... Including how to build-test and read them, and having CI complaining about invalid constructs.

MarijnS95 commented 3 months ago

What thought has gone into releasing 0.3.1 instead of 0.4.0? From what I can see there were breaking changes, such as:

https://github.com/Traverse-Research/ispc-downsampler/compare/0.3.0...main

maxded commented 3 months ago

Let's do a 0.4.0 release as we indeed have breaking changes since the previous release 😄.