TravisCarden / ddev-drupal-xb-dev

4 stars 3 forks source link

Update documentation to include database version #4

Open cosmicdreams opened 1 day ago

cosmicdreams commented 1 day ago

By using the default version number for the maria db instance, the installation process fails. You must first update the DB to 10.6 or higher in order to be compatible with version 11 (the version you documentation suggests to use).

Please considering adding a command line argument to declare the version of database that is needed.

rfay commented 1 day ago

Ddev's default is mariadb 10.11 though...

cosmicdreams commented 1 day ago

The test I did today was from a new computer using the Drupal project type. The config declared it's use of 10.4

TravisCarden commented 17 hours ago

This add-on doesn't directly control config details at that level. The config command from DDEV itself does--and it already has an option to specify the database: https://ddev.readthedocs.io/en/stable/users/usage/commands/#config. In this case, you would just modify the ddev config command in the README like this:

ddev config --project-type=drupal --php-version=8.3 --docroot=web --database=mariadb:10.11

I hate to hard-code that detail in the documentation. And since it seems, per @rfay, it's already supposed to default to the correct version, I'm inclined to close this issue until someone else reports having the problem. Does the above code solve the problem for you?

cosmicdreams commented 16 hours ago

If we're doing that should we talk about using mariadb vs MySQL?

On Mon, Oct 21, 2024, 3:21 PM Travis Carden @.***> wrote:

This add-on doesn't directly control config details at that level. The config command from DDEV itself does--and it already has an option to specify the database: https://ddev.readthedocs.io/en/stable/users/usage/commands/#config. In this case, you would just modify the ddev config command in the README http://../ like this:

ddev config --project-type=drupal --php-version=8.3 --docroot=web --database=mariadb:10.11

I hate to hard-code that detail in the documentation. And since it seems, per @rfay https://github.com/rfay, it's already supposed to default to the correct version, I'm inclined to close this issue until someone else reports having the problem. Does the above code solve the problem for you?

— Reply to this email directly, view it on GitHub https://github.com/TravisCarden/ddev-drupal-xb-dev/issues/4#issuecomment-2427641770, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGQA4HOPNDHKPVU2V3A4QLZ4VO3BAVCNFSM6AAAAABQI2VG7GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRXGY2DCNZXGA . You are receiving this because you authored the thread.Message ID: @.***>

rfay commented 14 hours ago

I don't know how you got a mariadb 10.4, would love you to look at recreating it.

MariaDB 10.11 became the default with DDEV v1.23.0 (April 2024), well before the drupal project type was introduced. So if you used a current DDEV version, it takes some applied effort to get 10.4.

I don't think people are likely to get 10.4 any way I know.

Your suggestion

ddev config --project-type=drupal --php-version=8.3 --docroot=web --database=mariadb:10.11

has essentially been out of date since the drupal project type was introduced. With the introduction of that, there's supposed to be a ddev config --update after the composer install is done. See https://ddev.readthedocs.io/en/stable/users/quickstart/#drupal

The idea is to not have to have a new drupal version all the time with different defaults, and instead to inspect the code and do the right thing.

The reality is that if you to a plain vanilla php installation with a drupal/recommended-project composer install and no other hints, ddev config --update will find the docroot, the drupal version, the php version required, and all.