search

TravisSpangle / redmine_spent_time_in_issue_description

Redmine Plugin that drops Time Entry data into the Issue Description
16 stars 16 forks source link

List the 'Time Spent' under or above the Associated Revisions #1

Closed optio closed 9 years ago

optio commented 10 years ago

Currently, the 'associated revisions' are listed in a floating right column next to the issue updates. Would it be possible to list the time spent there too ? cfr http://imgur.com/OJIsZ1Q

TravisSpangle commented 10 years ago

Perhaps, I haven't used the floating issue updates. I prefer this too and will take a look.

Pierstoval commented 10 years ago

What about this feature ? Any news ? :smiley:

TravisSpangle commented 10 years ago

I would like it. The reason I put in the configuration panel is so you could specify where it would appear. I haven't been able to get past that. Go for it if you'd like.

Pierstoval commented 10 years ago

Unfortunately I'm really not comfortable enough with Ruby (I don't know anything in Ruby, in fact), so that's why I thought it would not take much time to realize this feature.

If I understand anything in how you coded this plugin, it would not need many things :

  1. Add the parameter in the config panel which allows the user to show the time entries in 3 different places :
    • At the bottom of the issues' description
    • Above issues' revisions
    • Under issues' revisions
      1. Add the the partial for the revision top or bottom
      2. Add the parameter in the hook listener which makes the partial only appear according to the previously set parameter

Sorry for I don't know Ruby, but thanks anyway for answering :smile:

TravisSpangle commented 10 years ago

The challenge is there is no hook built into that part of the page. In order to get the data displayed I'll have to build it out in JavaScript which then adds it by manipulating the DOM.

Last time I looked into this I thought it would be possible but ugly. Now that I've got the other Issues knocked out I'll start looking this again.

TravisSpangle commented 9 years ago

OK initial changes are committed. I'll want to see if I can code it cleaner before I announce it on redmine.

johnquinnau commented 9 years ago

That's pretty exciting, it's working!

Thanks heaps.

John.

John Quinn Growth & Emerging Technologies Director ph: +61 4 2121 3331 - e: john@technocrat.com.au Melbourne - Canberra - Sydney - Brisbane Ph: 1300 830 500 Int: +61 2 6243 4866 technocrat.com.au http://www.technocrat.com.au/

UX AUSTRALIA PLATINUM SPONSOR DRUPALSOUTH 2014 GOLD SPONSOR DRUPALGOV CANBERRA 2014 GOLD SPONSOR DRUPALSOUTH MELBOURNE 2015 DIAMOND SPONSOR ACQUIA ENTERPRISE SELECT PARTNER & DRUPAL TRAINING PARTNER

This email and its contents are confidential and for use only by the intended recipient. If you have received it in error, please notify immediately by return email. Views and opinions are solely those of the author and do not necessarily represent those of Technocrat. Employees making defamatory statements or infringing on copyright or other legal rights operate contrary to company policy and Technocrat accepts no liability for such communications. No employee or agent is authorized to conclude any binding agreement on behalf of Technocrat with another party without express confirmation from the company director. Technocrat expects the recipient to take any steps necessary to prevent viruses and does not take any responsibility for loss or damage caused by viruses.

On 13 November 2014 12:08, Travis notifications@github.com wrote:

OK initial changes are committed. I'll want to see if I can code it cleaner before I announce it on redmine.

Reply to this email directly or view it on GitHub https://github.com/TravisSpangle/redmine_spent_time_in_issue_description/issues/1#issuecomment-62824706 .

TravisSpangle commented 9 years ago

This was completed in commit 71460ea7faacc79504a038cf3f731b347b1eff4a. I'm extending the Issue Show view. I no longer depend on Hooks and JavaScript to inject the HTML I want.

This will conflict with other plugins that extend the Show Issue View. I'll also need to keep any eye out for any changes made to that view by Redmine and patch my own.