search

TravisTheTechie / vscode-write-good

Write Good Linter for Visual Studio Code
MIT License
58 stars 7 forks source link

Only activates when Markdown language is selected #9

Closed jamievlin closed 6 years ago

jamievlin commented 6 years ago

Just to note, but if you're not using Markdown explicitly then the linter won't activate. (This includes LaTeX and other formats).

A quick ad-hoc fix is to add LaTeX to package activation criteria...

TravisTheTechie commented 6 years ago

The right fix, after talking to the VS Code folks, is to have it active all the item and just do the analysis based upon configured file types. I haven't done this yet. Let me take a swing at that and see if I can fix this issue more broadly easily. If not, I can add LaTeX as a short term file. I should add plaintext as well if I do that.

jamievlin commented 6 years ago

No worries! Thanks for the update. I know this is alot of work already and thanks for your work :)

TravisTheTechie commented 6 years ago

Oh a work around you can do, is have an empty markdown file in your project, open it up, then it should still work in LaTeX if you add LaTeX to your settings. You just have to open up a markdown file to activate the plugin. 

{
    "write-good.languages": [
        "markdown",
        "latex"
    ]
}
TravisTheTechie commented 6 years ago

4c627a81bf77914f0e4104edecc1ad2c9ba16384 should fix that. I am publishing a v0.0.8 now.

TravisTheTechie commented 6 years ago

Alright, I expected having to change the listener events but that wasn't required. This seems to work for me (using plaintext instead of markdown and getting immediate activation) and is published. Resolving. Please open up an issue if you run into problems.