Closed markvincze closed 6 years ago
Ah, we've been seeing those for years. Nice improvement.
I'm trying to find the original implementation in Netflix's version, but I can't find the source code for the used BucketCircularArray they use in their RollingNumber and RollingPercentile.
Ah, it's just Github's search that sucks. Here's the code:
Thanks @lucaslorentz for catching this issue!
Interesting, the AppVeyor build fails with an unrelated issue, and it also fails on my machine. I think some of the packages were changed on Nuget (something was maybe removed?), and that broke our build. I'm checking locally.
This was causing actual
IndexOutOfRangeException
s being thrown.