Travix-International / Hystrix.Dotnet

A combination of circuit breaker and timeout. The .net version of the open source Hystrix library built by Netflix.
https://travix-international.github.io/Hystrix.Dotnet/
MIT License
95 stars 16 forks source link

Owin middleware #19

Closed klettier closed 5 years ago

klettier commented 6 years ago

Hello,

I'm running a self hosted API with Owin and have implemented my own Owin middleware to replace the HystrixStreamHandler that I cannot use without IIS.

I would like to make a PR to provide the middleware code in his own project (Hystrix.Dotnet.Owin) but it would be great to have the configuration parsing shared accross both projects (Hystrix.Dotnet.AspNet and Hystrix.Dotnet.Owin) and so extracting that logic into another project Hystrix.Dotnet.WebConfiguration.

What do you think ?

kévin

klettier commented 6 years ago

Any chance to get an update on this ?

markvincze commented 6 years ago

Hi @klettier,

Sounds great, it'd be awesome to include this in the library.
Yep, I agree, the config parsing is complicated enough so that it's worth it to try to avoid duplicating it, extracting it to a common library sounds good to me. cc @JorritSalverda

klettier commented 6 years ago

Nice, here is where I am, don't hesitate to let me know what you think about it.

I will add the sample soon.

kévin