search

Travix-International / Hystrix.Dotnet

A combination of circuit breaker and timeout. The .net version of the open source Hystrix library built by Netflix.
https://travix-international.github.io/Hystrix.Dotnet/
MIT License
95 stars 16 forks source link

Update mvc dependency in sample to remove vulnerability warning #28

Closed baor closed 5 years ago

Prutswonder commented 5 years ago

👍

markvincze commented 5 years ago

Thanks! 👍 It's weird that one of the builds out of the two is failing (especially because those should be identical I think), maybe one of our tests is not isolated enough, so it fails randomly? I'll try to check.

markvincze commented 5 years ago

I could reproduce the failure locally, and indeed it's random, sometimes it fails, sometimes it passes.

I'll look into what this test is doing, and will try to fix it.

markvincze commented 5 years ago

Ok, I think what the problem is that the Dictionary we store the commands in is static. And Xunit by default is running the tests in parallel, so sometimes by chance tests step on each other's feet.

I added this commit to the branch to prevent the tests from failing.

I know that this is just hiding the symptom rather than a proper solution, but I don't want to spend more time on it now. (Probably that dictionary should be changed to be non-static, but I don't know what effects that would have.)
cc @JorritSalverda

baor commented 5 years ago

thank you, @markvincze !